From 17cc8e8e7f48f6d1fc618036448b4939e77429e6 Mon Sep 17 00:00:00 2001 From: Marco van Dijk Date: Fri, 3 Nov 2023 13:54:07 +0100 Subject: [PATCH] Correctly reuse cached domain if a later lookup returns null --- master/src/routes/hodler.js | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/master/src/routes/hodler.js b/master/src/routes/hodler.js index 9f88c96..2437064 100644 --- a/master/src/routes/hodler.js +++ b/master/src/routes/hodler.js @@ -134,7 +134,18 @@ const getEnsDomain = async function (addr) { ); ensDomainCache[addr] = ensObj; await storage.setItem("ensDomainCache", ensDomainCache); - return ensObj.domain ? ensObj.domain : ensObj.address; + if (ensObj.domain) { + // Update domain name + return ensObj.domain; + } else { + if (cached.domain) { + // Reuse last cached domain + return cached.domain; + } else { + // Return ETH addr + return ensObj.address; + } + } } catch (err) { console.log(err); console.log("Error looking up ENS info, retrying...");