Correctly reuse cached domain if a later lookup returns null

This commit is contained in:
Marco van Dijk 2023-11-03 13:54:07 +01:00
parent 46305d97e8
commit 17cc8e8e7f

View File

@ -134,7 +134,18 @@ const getEnsDomain = async function (addr) {
); );
ensDomainCache[addr] = ensObj; ensDomainCache[addr] = ensObj;
await storage.setItem("ensDomainCache", ensDomainCache); await storage.setItem("ensDomainCache", ensDomainCache);
return ensObj.domain ? ensObj.domain : ensObj.address; if (ensObj.domain) {
// Update domain name
return ensObj.domain;
} else {
if (cached.domain) {
// Reuse last cached domain
return cached.domain;
} else {
// Return ETH addr
return ensObj.address;
}
}
} catch (err) { } catch (err) {
console.log(err); console.log(err);
console.log("Error looking up ENS info, retrying..."); console.log("Error looking up ENS info, retrying...");